slachiewicz commented on code in PR #165:
URL: https://github.com/apache/maven-parent/pull/165#discussion_r1899851867
##########
pom.xml:
##########
@@ -944,8 +944,7 @@ under the License.
<properties>
<javaVersion>8</javaVersion>
- <maven.compiler.source>${javaVersion}</maven.compiler.source>
- <maven.compiler.target>${javaVersion}</maven.compiler.target>
+ <maven.compiler.release>${javaVersion}</maven.compiler.release>
Review Comment:
> Since version 3.13.0 of the Compiler Plugin together with the default
javac compilerId you don't need conditional parametrisation of release. The
release parameter will only be effective for Java 9 or above, otherwise the
source and target will be passed to the compiler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
