Stellar1999 commented on code in PR #248:
URL: https://github.com/apache/maven-archetype/pull/248#discussion_r1885687234


##########
archetype-common/src/main/java/org/apache/maven/archetype/common/util/FileCharsetDetector.java:
##########


Review Comment:
   > It is not a good idea for me to remove this util class. What benefit is 
for it?
   > 
   > We add a new code to `FilesetArchetypeCreator` which is already big today.
   
   Where can I find the updated code? I'd like to review the changes and learn 
from them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to