slawekjaranowski commented on code in PR #248: URL: https://github.com/apache/maven-archetype/pull/248#discussion_r1885685788
########## archetype-common/src/main/java/org/apache/maven/archetype/common/util/FileCharsetDetector.java: ########## Review Comment: When we remove such class we assume that it is no an API ... ... by the way I don't recognize Maven plugin as library so there is no Api ... Big class with 1.6K lines with many private methods is difficult to read, understand and even more to test - it is my opinion ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
