elharo commented on code in PR #91:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/91#discussion_r1885428119
##########
src/main/java/org/apache/maven/report/projectinfo/DependenciesReport.java:
##########
@@ -205,45 +205,27 @@ private DependencyNode resolveProject() {
* @throws IOException if any
*/
private void copyResources(File outputDirectory) throws IOException {
- InputStream resourceList = null;
- InputStream in = null;
- BufferedReader reader = null;
- OutputStream out = null;
- try {
- resourceList =
getClass().getClassLoader().getResourceAsStream(RESOURCES_DIR +
"/resources.txt");
-
- if (resourceList != null) {
- reader = new LineNumberReader(new
InputStreamReader(resourceList, ReaderFactory.US_ASCII));
-
+ InputStream resourceList =
getClass().getClassLoader().getResourceAsStream(RESOURCES_DIR +
"/resources.txt");
Review Comment:
I'm not sure how to do the null check if I put it there. Closing the
wrapping reader should close the input stream if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
