[
https://issues.apache.org/jira/browse/MSKINS-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897626#comment-17897626
]
Michael Osipov edited comment on MSKINS-230 at 11/12/24 4:04 PM:
-----------------------------------------------------------------
It is broken already even without the skin. consider you create an empty skin
and write some content, since there is no CSS, then th will be centered and td
will be left-aligned of justification in not provided by the sink. The reason
why it previously "worked" is that by chance Boostrap did a left align we did
not pay attention to. So it is broken-broken. We can either fix the skin which
will result in broken-fixed, or make no assumptions about the alignment and
make it a discretion of the output format. I.e., if you don't explicitly
define, the skin/output renderer will deside. Consider you are writiing RTL,
Hebrew or Arabic, then then LTR approach does not make sense and I am sure that
the browse will apply the reverse by default.
I'd simply remove the notion from the API. WDYT?
was (Author: michael-o):
It is broken already even without the skin. consider you create an empty skin
and write some content, since there is no CSS, then th will be centered and td
will be left-aligned of justification in not provided by the sink. The reason
why it previously "worked" is that by chance Boostrap did a left align we did
not pay attention to. So it is broken-broken. We can either fix the skin which
will result in broken-fixed, or make no assumptions about the alignment and
make it a discretion of the output format. I.e., if you don't explicitly
define, the skin/output renderer will deside. Consider you are writiing RTL,
Hebrew or Arabic, then then LTR approach does not make sense and I am sure that
the browse will apply the reverse by default.
> Text in <th>/<td> ignore default alignment
> ------------------------------------------
>
> Key: MSKINS-230
> URL: https://issues.apache.org/jira/browse/MSKINS-230
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-2.0.0-M6
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: fluido-2.0.0-M7, fluido-1.12.0, fluido-2.0.0
>
>
> Table (header) cells lose default alignment because Bootstrap by default
> enforces:
> {noformat}
> .table th,
> .table td {
> padding: 8px;
> line-height: 20px;
> text-align: left;
> vertical-align: top;
> border-top: 1px solid #dddddd;
> } {noformat}
> We need to revert it and not enfore any alignment otherwise {{<th>}} elements
> aren't centered anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
