kwin commented on PR #573:
URL: https://github.com/apache/maven-site/pull/573#issuecomment-2455318587

   > Next diff: Code blocks from APT, not verbatim ones are lost, so is 
autohighlight. Example: developers/committer-settings.html
   
   Well, https://maven.apache.org/developers/committer-settings.html has the 
following APT: 
https://github.com/apache/maven-site/blob/923f866d01b9f54c436d3e30f1c2789b45b4affe/content/apt/developers/committer-settings.apt#L41-L60
   
   According to 
https://maven.apache.org/doxia/references/apt-format.html#verbatim-text this is 
just verbatim text with a box around it.
   This is converted to 
https://github.com/apache/maven-site/pull/573/files#diff-ad6899066ecffca374fb2b9eb533e56c42e397026a9a577f78c42ac3fae9902cR36.
   
   I see that the HTML generated out of the converted MD is lacking the 
hightlighting and line number, but I think this is due to 
https://issues.apache.org/jira/browse/MSKINS-245 because the HTML looks good to 
me i.e. enclosed in {{<pre><code>...</code></pre>). In MD every verbatim text 
is emitted in code blocks!
   
   What exactly do you consider wrong here @michael-o ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to