elharo commented on code in PR #790:
URL: https://github.com/apache/maven-surefire/pull/790#discussion_r1813051391
##########
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java:
##########
@@ -64,6 +69,49 @@ public void testSkipped() throws Exception {
writeReadCheck(new RunResult(3, 2, 1, 0, null, true));
}
+ @Test
+ public void testFlakes() throws Exception {
+ writeReadCheck(new RunResult(3, 2, 1, 0, 2, null, true));
+ }
+
+ @Test
+ public void testLegacyDeserialization() throws Exception {
Review Comment:
I 100% disagree. Consistency with imperfect code is **not** a virtue. New
code should follow best practices, even when the old code does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
