[
https://issues.apache.org/jira/browse/MARTIFACT-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891589#comment-17891589
]
ASF GitHub Bot commented on MARTIFACT-75:
-----------------------------------------
hboutemy commented on code in PR #66:
URL:
https://github.com/apache/maven-artifact-plugin/pull/66#discussion_r1809125314
##########
src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java:
##########
@@ -213,8 +214,10 @@ private ReproducibleEnv extractEnv(File file, Artifact
artifact) {
} else {
log.warn("no MANIFEST.MF found in jar " + file);
}
+ } catch (ZipException e) {
+ log.warn("Corrupt jar file " + file + "\n" + e.getMessage());
} catch (IOException e) {
- log.warn("unable to open jar file " + file, e);
+ log.warn("unable to read jar file " + file + "\n" +
e.getMessage());
Review Comment:
thinking again at it: if we do that, we need to display the exception class
like if the exception message was the first line of the stacktrace, as it
brings useful info = the type of issue
with that pattern, ok, the rest of the stacktrace can be ignored
> stacktrace when running compare: trying to open .pom file as zip
> ----------------------------------------------------------------
>
> Key: MARTIFACT-75
> URL: https://issues.apache.org/jira/browse/MARTIFACT-75
> Project: Maven Artifact Plugin
> Issue Type: Bug
> Components: artifact:compare
> Affects Versions: 3.5.2
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.3
>
>
> # when rebuilding
> https://github.com/jvm-repo-rebuild/reproducible-central/pull/437
> just a warning, does not fail anything, but noisy
> {noformat}
> [INFO] --- artifact:3.5.2:compare (default-cli) @ nisse ---
> [INFO] Reference buildinfo file not found: it will be generated from
> downloaded reference artifacts
> [WARNING] unable to open jar file
> /var/maven/app/target/reference/eu.maveniverse.maven.nisse/nisse-0.3.3.pom
> java.util.zip.ZipException: zip END header not found
> at java.util.zip.ZipFile$Source.findEND (ZipFile.java:1649)
> at java.util.zip.ZipFile$Source.initCEN (ZipFile.java:1657)
> at java.util.zip.ZipFile$Source.<init> (ZipFile.java:1495)
> at java.util.zip.ZipFile$Source.get (ZipFile.java:1458)
> at java.util.zip.ZipFile$CleanableResource.<init> (ZipFile.java:724)
> at java.util.zip.ZipFile.<init> (ZipFile.java:251)
> at java.util.zip.ZipFile.<init> (ZipFile.java:180)
> at java.util.jar.JarFile.<init> (JarFile.java:345)
> at java.util.jar.JarFile.<init> (JarFile.java:316)
> at java.util.jar.JarFile.<init> (JarFile.java:282)
> at
> org.apache.maven.plugins.artifact.buildinfo.ReferenceBuildinfoUtil.extractEnv
> (ReferenceBuildinfoUtil.java:207)
> at
> org.apache.maven.plugins.artifact.buildinfo.ReferenceBuildinfoUtil.downloadOrCreateReferenceBuildinfo
> (ReferenceBuildinfoUtil.java:131)
> at
> org.apache.maven.plugins.artifact.buildinfo.CompareMojo.downloadOrCreateReferenceBuildinfo
> (CompareMojo.java:144)
> at
> org.apache.maven.plugins.artifact.buildinfo.CompareMojo.checkAgainstReference
> (CompareMojo.java:131)
> at org.apache.maven.plugins.artifact.buildinfo.CompareMojo.skip
> (CompareMojo.java:115)
> at
> org.apache.maven.plugins.artifact.buildinfo.AbstractBuildinfoMojo.execute
> (AbstractBuildinfoMojo.java:160)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
