cstamas commented on code in PR #1700:
URL: https://github.com/apache/maven/pull/1700#discussion_r1773711239
##########
maven-core/src/main/java/org/apache/maven/internal/transformation/impl/DefaultConsumerPomBuilder.java:
##########
@@ -79,71 +78,74 @@ class DefaultConsumerPomBuilder implements
ConsumerPomBuilder {
public static final String POM_PACKAGING = "pom";
- @Inject
- private ProfileInjector profileInjector;
-
- @Inject
- private InheritanceAssembler inheritanceAssembler;
-
- @Inject
- private DependencyManagementImporter dependencyManagementImporter;
-
- @Inject
- private DependencyManagementInjector dependencyManagementInjector;
-
- @Inject
- private LifecycleBindingsInjector lifecycleBindingsInjector;
-
- @Inject
- private ModelInterpolator modelInterpolator;
-
- @Inject
- private ModelNormalizer modelNormalizer;
-
- @Inject
- private ModelPathTranslator modelPathTranslator;
-
- @Inject
- private ModelProcessor modelProcessor;
-
- @Inject
- private ModelUrlNormalizer modelUrlNormalizer;
-
- @Inject
- private ModelValidator modelValidator;
+ private final ProfileInjector profileInjector;
+ private final InheritanceAssembler inheritanceAssembler;
+ private final DependencyManagementImporter dependencyManagementImporter;
+ private final DependencyManagementInjector dependencyManagementInjector;
+ private final LifecycleBindingsInjector lifecycleBindingsInjector;
+ private final ModelInterpolator modelInterpolator;
+ private final ModelNormalizer modelNormalizer;
+ private final ModelPathTranslator modelPathTranslator;
+ private final ModelProcessor modelProcessor;
+ private final ModelUrlNormalizer modelUrlNormalizer;
+ private final ModelValidator modelValidator;
+ private final PluginConfigurationExpander pluginConfigurationExpander;
+ private final PluginManagementInjector pluginManagementInjector;
+ private final SuperPomProvider superPomProvider;
+ private final ModelVersionParser versionParser;
+ // To break circular dependency private final
Provider<RepositorySystem> repositorySystem;
Review Comment:
drop this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
