[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884024#comment-17884024
]
ASF GitHub Bot commented on DOXIA-740:
--------------------------------------
kwin commented on code in PR #228:
URL: https://github.com/apache/maven-doxia/pull/228#discussion_r1771991131
##########
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexingSink.java:
##########
@@ -150,14 +158,20 @@ public void text(String text, SinkEventAttributes
attributes) {
case SECTION_3:
case SECTION_4:
case SECTION_5:
+ case SECTION_6:
//
-----------------------------------------------------------------------
// Sanitize the id. The most important step is to remove
any blanks
//
-----------------------------------------------------------------------
// append text to current entry
IndexEntry entry = stack.lastElement();
- String title = entry.getTitle() + text;
+ String title;
Review Comment:
Because entry.getTitle() might return null
> Rendering Markdown silently truncates files that skip a heading level
> ---------------------------------------------------------------------
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
> Affects Versions: 2.0.0-M9
> Reporter: John Dimeo
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: 2.0.0
>
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
