[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882498#comment-17882498
]
ASF GitHub Bot commented on DOXIA-740:
--------------------------------------
kwin commented on code in PR #228:
URL: https://github.com/apache/maven-doxia/pull/228#discussion_r1763757207
##########
doxia-core/src/main/java/org/apache/maven/doxia/macro/toc/TocMacro.java:
##########
@@ -112,9 +113,13 @@ public void execute(Sink sink, MacroRequest request)
throws MacroExecutionExcept
tocSink.close();
}
- IndexEntry index = tocSink.getRootEntry();
+ writeTocForIndexEntry(sink,
getAttributesFromMap(request.getParameters()), tocSink.getRootEntry());
+ }
+
+ void writeTocForIndexEntry(Sink sink, SinkEventAttributes listAttributes,
IndexEntry rootEntry) {
Review Comment:
This still needs some work to
a) only consider entries for type section
b) skip empty entries (not having an id)
> Rendering Markdown silently truncates files that skip a heading level
> ---------------------------------------------------------------------
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
> Reporter: John Dimeo
> Assignee: Konrad Windszus
> Priority: Major
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
