michael-o commented on code in PR #165:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/165#discussion_r1720363386
##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##########
@@ -243,23 +246,22 @@ private void addModuleFiles(
//
-----------------------------------------------------------------------
// Handle key without case differences
//
-----------------------------------------------------------------------
- for (Map.Entry<String, DocumentRenderer> entry :
files.entrySet()) {
- if (entry.getKey().equalsIgnoreCase(key)) {
- DocumentRenderingContext originalDocRenderingContext =
- entry.getValue().getRenderingContext();
+ String originalKey =
caseInsensitiveFiles.put(key.toLowerCase(), key);
Review Comment:
No, I would expect the system to work identically on the same OS regardless
of the actual locally used. This we want to avoid:
https://reproducible-builds.org/docs/locales/ to stuff like with `tr_TR` and
the dotless I.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
