jdimeo commented on code in PR #165:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/165#discussion_r1720348354
##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##########
@@ -243,23 +246,22 @@ private void addModuleFiles(
//
-----------------------------------------------------------------------
// Handle key without case differences
//
-----------------------------------------------------------------------
- for (Map.Entry<String, DocumentRenderer> entry :
files.entrySet()) {
- if (entry.getKey().equalsIgnoreCase(key)) {
- DocumentRenderingContext originalDocRenderingContext =
- entry.getValue().getRenderingContext();
+ String originalKey =
caseInsensitiveFiles.put(key.toLowerCase(), key);
Review Comment:
I thought the purpose of this code was to flag potential file key conflicts
_on the build system_ specifically handling Linux vs. Windows etc. So wouldn't
it be good to flag a casing conflict for the build system's default locale? If
I use root, it may not flag it for my particular laptop's build. Easy to
change if you don't agree, just genuinely curious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
