[
https://issues.apache.org/jira/browse/MNG-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864375#comment-17864375
]
ASF GitHub Bot commented on MNG-8179:
-------------------------------------
michael-o commented on code in PR #1605:
URL: https://github.com/apache/maven/pull/1605#discussion_r1671211174
##########
maven-core/src/test/resources/project-dynamism/pom.xml:
##########
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
-<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
+<project
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
<modelVersion>4.0.0</modelVersion>
Review Comment:
Is this change intended? all of these POMs were invalid because they aren't
in the target namespace and if you don't sue the `xsi` NS why declare it?
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsXmlFactory.java:
##########
@@ -53,10 +52,6 @@ public PersistedToolchains read(@Nonnull XmlReaderRequest
request) throws XmlRea
throw new IllegalArgumentException("reader or inputStream must be
non null");
}
try {
- InputSource source = null;
- if (request.getModelId() != null || request.getLocation() != null)
{
- source = new InputSource(request.getModelId(),
request.getLocation());
- }
Review Comment:
This is weird, source is never used? Was this found part of a new
rule/detection?
##########
pom.xml:
##########
@@ -24,7 +24,7 @@ under the License.
<groupId>org.apache.maven</groupId>
<artifactId>maven-parent</artifactId>
<!
> Upgrade Parent to 43
> --------------------
>
> Key: MNG-8179
> URL: https://issues.apache.org/jira/browse/MNG-8179
> Project: Maven
> Issue Type: Dependency upgrade
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: 4.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
