[
https://issues.apache.org/jira/browse/MNG-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864669#comment-17864669
]
ASF GitHub Bot commented on MNG-8179:
-------------------------------------
gnodet commented on code in PR #1605:
URL: https://github.com/apache/maven/pull/1605#discussion_r1672307289
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsXmlFactory.java:
##########
@@ -53,10 +52,6 @@ public PersistedToolchains read(@Nonnull XmlReaderRequest
request) throws XmlRea
throw new IllegalArgumentException("reader or inputStream must be
non null");
}
try {
- InputSource source = null;
- if (request.getModelId() != null || request.getLocation() != null)
{
- source = new InputSource(request.getModelId(),
request.getLocation());
- }
Review Comment:
We can get rid of this code, I'll provide a PR to add proper location
tracking to toolchains.
> Upgrade Parent to 43
> --------------------
>
> Key: MNG-8179
> URL: https://issues.apache.org/jira/browse/MNG-8179
> Project: Maven
> Issue Type: Dependency upgrade
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: 4.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
