cstamas commented on code in PR #225:
URL: 
https://github.com/apache/maven-shade-plugin/pull/225#discussion_r1616023393


##########
pom.xml:
##########
@@ -93,12 +92,12 @@
       <dependency>
         <groupId>org.eclipse.sisu</groupId>
         <artifactId>org.eclipse.sisu.inject</artifactId>
-        <version>${sisu.version}</version>
+        <version>${version.sisu-maven-plugin}</version>

Review Comment:
   Yes, is ugly, will figure out something. My point was really to not have 
"disconnected" the sisu version in this plugin vs parent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to