cstamas commented on code in PR #225:
URL:
https://github.com/apache/maven-shade-plugin/pull/225#discussion_r1616008558
##########
pom.xml:
##########
@@ -185,21 +181,21 @@
<artifactId>maven-dependency-tree</artifactId>
<version>3.2.1</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
Review Comment:
? unsure I get your comment. If you'd look carefully, you will see that I
just moved this dependency from last place (as it is non test) to here. I just
"moved" it to have proper dep order.
##########
pom.xml:
##########
@@ -185,21 +181,21 @@
<artifactId>maven-dependency-tree</artifactId>
<version>3.2.1</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-compress</artifactId>
+ <version>1.26.2</version>
+ </dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.13.0</version>
+ <version>2.16.1</version>
Review Comment:
changed the subject
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
