olamy commented on code in PR #225:
URL:
https://github.com/apache/maven-shade-plugin/pull/225#discussion_r1615931342
##########
pom.xml:
##########
@@ -185,21 +181,21 @@
<artifactId>maven-dependency-tree</artifactId>
<version>3.2.1</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-compress</artifactId>
+ <version>1.26.2</version>
+ </dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.13.0</version>
+ <version>2.16.1</version>
Review Comment:
this doesn't look related to the subject of the PR
maybe change the subject
##########
pom.xml:
##########
@@ -79,12 +79,11 @@
</distributionManagement>
<properties>
- <mavenVersion>3.6.3</mavenVersion>
+ <mavenVersion>3.9.7</mavenVersion>
Review Comment:
this doesn't look related to the subject of the PR
maybe change the subject
##########
pom.xml:
##########
@@ -93,12 +92,12 @@
<dependency>
<groupId>org.eclipse.sisu</groupId>
<artifactId>org.eclipse.sisu.inject</artifactId>
- <version>${sisu.version}</version>
+ <version>${version.sisu-maven-plugin}</version>
Review Comment:
the property name doesn't look related to such library.
I know it's coming from the parent but this is really confusing.
##########
pom.xml:
##########
@@ -185,21 +181,21 @@
<artifactId>maven-dependency-tree</artifactId>
<version>3.2.1</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
Review Comment:
? really needed? this doesn't look related to the subject of the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
