gnodet commented on code in PR #1510: URL: https://github.com/apache/maven/pull/1510#discussion_r1609369940
########## maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java: ########## @@ -23,17 +23,7 @@ import java.nio.file.Path; import java.nio.file.Paths; -import java.util.Arrays; -import java.util.Collection; -import java.util.Collections; -import java.util.EnumSet; -import java.util.HashMap; -import java.util.LinkedHashMap; -import java.util.LinkedHashSet; -import java.util.List; -import java.util.Locale; -import java.util.Map; -import java.util.Set; +import java.util.*; Review Comment: spotless and impsort plugins can't fix star -> individual imports because that would require access to the full class path and they really only operate on a single file. That also mean the opposite (so I was wrong), i.e. they won't refactor multiple imports into a single one I think. It must have been the IDE. Which means the PR should not contain the star. @slawekjaranowski it seems the AvoidStarImport is [no more enforced](https://github.com/apache/maven-shared-resources/blob/maven-shared-resources-5/src/main/resources/config/maven_checks_nocodestyle.xml). I think we removed it based on the assumption that it was handled by spotless/impsort, but that does not seem to be the case @yuehcw can you remove the star import ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
