[ 
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843549#comment-17843549
 ] 

ASF GitHub Bot commented on MINVOKER-335:
-----------------------------------------

slawekjaranowski commented on code in PR #237:
URL: 
https://github.com/apache/maven-invoker-plugin/pull/237#discussion_r1590271101


##########
src/it/MINVOKER-335-symlinks-in-source/selector.groovy:
##########
@@ -28,7 +28,12 @@ def testFile = projectPath.resolve('test.txt')
 Files.createDirectory(testDir)
 Files.createFile(testFile)
 
-Files.createSymbolicLink(projectPath.resolve('testDirLink'), 
Paths.get('testDir'))
-Files.createSymbolicLink(projectPath.resolve('testLink.txt'), 
Paths.get('test.txt'))
+// if FS not supports symlinks - we should skip test

Review Comment:
   done





> Symlinks from source project are copied as file
> -----------------------------------------------
>
>                 Key: MINVOKER-335
>                 URL: https://issues.apache.org/jira/browse/MINVOKER-335
>             Project: Maven Invoker Plugin
>          Issue Type: Bug
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.7.0
>
>
> Source project:
> {noformat}
> -rw-r--r--  1 xxx  40 May  1 18:44 test.txt
> drwxr-xr-x  2 xxx  64 May  1 19:26 testDir
> lrwxr-xr-x  1 xxx   7 May  1 19:27 testDirLink -> testDir
> lrwxr-xr-x  1 xxx   8 May  1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r--  1 xxx  40 May  1 18:44 test.txt
> drwxr-xr-x  2 xxx  64 May  1 19:30 testDir
> lrwxr-xr-x  1 xxx   7 May  1 19:30 testDirLink -> testDir
> -rw-r--r--  1 xxx  40 May  1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to