[
https://issues.apache.org/jira/browse/MARTIFACT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832921#comment-17832921
]
ASF GitHub Bot commented on MARTIFACT-59:
-----------------------------------------
rmannibucau commented on PR #30:
URL:
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2030278980
> wrong, they use everything, and it works: I still don't get what needs to
be changed in maven-artifact-plugin
wrong (ok was cause it made me smile to read it)
please just run `buildinfo` goal and you'll get in the parent - as explained
in my comment:
> [WARNING] Reproducible Build not activated by
project.build.outputTimestamp property: see
https://maven.apache.org/guides/mini/guide-reproducible-builds.html
Which is *not* a "it works as expected" behavior for me. My setup with
git-commit-id works similarly but a warning in the build is just a sign it is
buggy by design and there it is technically justifiable too.
Now, as mentionned, run `mvn artifact:check-buildplan` and you get - still
in the parent but you get it:
> [ERROR] Reproducible Build not activated by project.build.outputTimestamp
property: see
https://maven.apache.org/guides/mini/guide-reproducible-builds.html
and a nice
> [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-artifact-plugin:3.5.0:check-buildplan
(default-cli) on project moditect-parent: non-reproducible plugin or
configuration found with fix available -> [Help 1]
which breaks the build.
So no, it does not work for them.
> artifact plugin should tolerate injected project.build.outputTimestamp
> ----------------------------------------------------------------------
>
> Key: MARTIFACT-59
> URL: https://issues.apache.org/jira/browse/MARTIFACT-59
> Project: Maven Artifact Plugin
> Issue Type: Improvement
> Reporter: Romain Manni-Bucau
> Priority: Minor
> Labels: pull-request-available
>
> Goal is to not log
> {code:java}
> Reproducible Build not activated by project.build.outputTimestamp property:
> see https://maven.apache.org/guides/mini/guide-reproducible-builds.html {code}
> when the project is actually set but computed from another property and not
> fail (check mojo) when the setup is the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
