[
https://issues.apache.org/jira/browse/MARTIFACT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832340#comment-17832340
]
ASF GitHub Bot commented on MARTIFACT-59:
-----------------------------------------
hboutemy commented on PR #30:
URL:
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2027862052
> long story short it is
<project.build.outputTimestamp>${git.commit.time}</project.build.outputTimestamp>
like usages.
thanks: it's the first step into describing: then what is the symptom? what
happens when you do that, that you want to change?
> I thought about your position to say it is wrong to not hardcode it, if
this PR is really not an option, I think I could "not care" about it if the
value is automatically rewritten by a plugin.
> I'm not yet sure of the best plugin for that - artifact looks wrong,
git-commit-id too, spotless or pom rewriters don't know about last change date
so not yet fixed on where.
what I say is that using git commit is not the most efficient, because it
changes on each commit even if the jar file content does not really change:
then it forces jar update only for timestamp.
Having a value hard coded + maven-release-plugin and versions-maven-plugin
update/rewrite when version is updated is the most efficient strategy found so
far: I know it's not a usual strategy, but it never creates a different jar
when it is not necessary because its content has really changed.
But I don't fight hard against people wanting to use git commit: from a
theoretical perspective, I understand it looks more natural. If you want to go
that route, no problem. If you experience a problem maven-artifact-plugin, I
just need to see what concrete problem is caused by what goal of
maven-artifact-plugin for you when doing that strategy, to understand how to
update the code to precisely detect that case and not have unintended side
effects.
FYI, moditect uses the git commit strategy and there is no issue for them:
https://github.com/moditect/moditect =>
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/moditect/moditect/README.md
> artifact plugin should tolerate injected project.build.outputTimestamp
> ----------------------------------------------------------------------
>
> Key: MARTIFACT-59
> URL: https://issues.apache.org/jira/browse/MARTIFACT-59
> Project: Maven Artifact Plugin
> Issue Type: Improvement
> Reporter: Romain Manni-Bucau
> Priority: Minor
> Labels: pull-request-available
>
> Goal is to not log
> {code:java}
> Reproducible Build not activated by project.build.outputTimestamp property:
> see https://maven.apache.org/guides/mini/guide-reproducible-builds.html {code}
> when the project is actually set but computed from another property and not
> fail (check mojo) when the setup is the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
