rmannibucau commented on code in PR #200:
URL:
https://github.com/apache/maven-compiler-plugin/pull/200#discussion_r1513106708
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -279,8 +279,11 @@ public abstract class AbstractCompilerMojo extends
AbstractMojo {
* <ul>
* <li><code>none</code> - no annotation processing is performed.</li>
* <li><code>only</code> - only annotation processing is done, no
compilation.</li>
+ * <li><code>full</code> - annotation processing and compilation.</li>
* </ul>
*
+ * <code>full</code> is the default. Starting with JDK 21, this option
must be set explicitly.
Review Comment:
> We can use conditions depending on the javac version
fact is we don't know with javac version what is supported since several
vendors did backport full support.
> we can add a property for proc parameter and property can be overridden in
child modules with empty value.
It is already the case AFAIK (side note being adding properties for compiler
args is quite misleading and lead to broken configuration more than it helps
IMHO).
->
https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#proc
Think we don't have much choice to split the default compilation in 2 runs
if there is at least one processor available (path or serviceloader discovery)
and proc is not configured in compiler properties or args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
