jddarcy commented on code in PR #200:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/200#discussion_r1512085550


##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -279,8 +279,11 @@ public abstract class AbstractCompilerMojo extends 
AbstractMojo {
      * <ul>
      * <li><code>none</code> - no annotation processing is performed.</li>
      * <li><code>only</code> - only annotation processing is done, no 
compilation.</li>
+     * <li><code>full</code> - annotation processing and compilation.</li>
      * </ul>
      *
+     * <code>full</code> is the default. Starting with JDK 21, this option 
must be set explicitly.

Review Comment:
   > Another solution (which is probably intended by the JDK folks): I used to 
do two executions in my projects:
   > 
   >     * generate-sources: execute with `proc:only`
   > 
   >     * default-compile: execute with `proc:none`
   > 
   > 
   > Worked like a charm and only changed it because Tamas hinted me to do so 
(because with this setup, some things like caching, incremental compilation 
etc. won't work that well or not at all). However, this solution would not run 
into those problems at all.
   
   Just running annotation processing when there is explicit need and intention 
to do so would be fine too.
   
   The warning note is only printed when annotation processing by default is 
being used. If there is explicit configuration annotation processing related 
options, like `-processorpath` the note is not printed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to