slawekjaranowski commented on code in PR #432:
URL: https://github.com/apache/maven-resolver/pull/432#discussion_r1501441193


##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:
##########
@@ -151,7 +162,23 @@ private DeployResult deploy(SyncContext syncContext, 
RepositorySystemSession ses
             throw new DeploymentException("Failed to deploy 
artifacts/metadata: " + e.getMessage(), e);
         }
 
+        List<Artifact> artifacts = new ArrayList<>(request.getArtifacts());
+        List<? extends ArtifactGenerator> artifactGenerators = 
getArtifactGenerators(session, request);
         try {
+            List<Artifact> generatedArtifacts = new ArrayList<>();
+            for (ArtifactGenerator artifactGenerator : artifactGenerators) {
+                Collection<? extends Artifact> generated = 
artifactGenerator.generate(generatedArtifacts);

Review Comment:
   ok - I see we heve materialized artifact list in 
`org.eclipse.aether.generator.signer.SignerArtifactGenerator`
   It is look too complicated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to