cstamas commented on PR #432: URL: https://github.com/apache/maven-resolver/pull/432#issuecomment-1960029880
For other a general answer: I do agree with all your comments, but * Resolver whole codebase is done as this, and we may want to change all these, but for now there are a lot of package protected and final classes, I did not want to disturb this coherence. But I do agree about non-final/public/protected fields. * BUT, extending JSR330 annotated component is a no-no (hence final) * I like how these classes are being prevented to be tampered with. If someone needs this, can copy, but I don't want to be hindered a year after, as somecome tells me I broke "compatibility" with his app (where he uses or extends these classes). So, yes, I agree, but this is why not IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
