cstamas commented on PR #432: URL: https://github.com/apache/maven-resolver/pull/432#issuecomment-1962919989
> Now that you put it that way, I'm not really convinced we need a Signer SPI here. The code of the ArtifactGenerator which calls the signers is trivial, so it seems to me that the GpgSigner could directly implement the Artifact Generator SPI. Agreed, will simplify it more, but the question begs: "generator-signer" module becomes wrong, no? Should it be maybe "generator-gnupg (or gpg)" instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
