[ https://issues.apache.org/jira/browse/MRESOLVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820315#comment-17820315 ]
ASF GitHub Bot commented on MRESOLVER-301: ------------------------------------------ slawekjaranowski commented on code in PR #432: URL: https://github.com/apache/maven-resolver/pull/432#discussion_r1501404200 ########## maven-resolver-generator-signer/src/main/java/org/eclipse/aether/generator/signer/SignerArtifactGeneratorFactory.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.eclipse.aether.generator.signer; + +import javax.inject.Inject; +import javax.inject.Named; +import javax.inject.Singleton; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Map; + +import org.eclipse.aether.RepositorySystemSession; +import org.eclipse.aether.artifact.Artifact; +import org.eclipse.aether.deployment.DeployRequest; +import org.eclipse.aether.installation.InstallRequest; +import org.eclipse.aether.repository.ArtifactRepository; +import org.eclipse.aether.spi.artifact.generator.ArtifactGenerator; +import org.eclipse.aether.spi.artifact.generator.ArtifactGeneratorFactory; + +@Singleton +@Named(SignerArtifactGeneratorFactory.NAME) +public final class SignerArtifactGeneratorFactory implements ArtifactGeneratorFactory { Review Comment: It is only one implementation of `SignerArtifactGeneratorFactory` why we put it in new module ... maybe should be in `maven-resolver-impl` ########## maven-resolver-generator-signer/src/main/java/org/eclipse/aether/generator/signer/SignerFactory.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.eclipse.aether.generator.signer; + +import org.eclipse.aether.RepositorySystemSession; +import org.eclipse.aether.repository.ArtifactRepository; + +/** + * Component creating {@link Signer} instances. + * + * @since 2.0.0 + */ +public interface SignerFactory { Review Comment: next factory similar to `ArtifactGeneratorFactory` ########## maven-resolver-demos/maven-resolver-demo-snippets/pom.xml: ########## @@ -34,8 +34,8 @@ <properties> <Automatic-Module-Name>org.apache.maven.resolver.demo.snippets</Automatic-Module-Name> - <! > Artifact Generators > ------------------- > > Key: MRESOLVER-301 > URL: https://issues.apache.org/jira/browse/MRESOLVER-301 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver > Reporter: Tamas Cservenak > Assignee: Tamas Cservenak > Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-9 > > > Resolver should provide extension point for "generators". Typical use case > for these are for example "signing" of artifacts. -- This message was sent by Atlassian Jira (v8.20.10#820010)