[ 
https://issues.apache.org/jira/browse/MRESOLVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819763#comment-17819763
 ] 

ASF GitHub Bot commented on MRESOLVER-301:
------------------------------------------

cstamas commented on code in PR #432:
URL: https://github.com/apache/maven-resolver/pull/432#discussion_r1499720008


##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:
##########
@@ -95,53 +106,96 @@ private InstallResult install(SyncContext syncContext, 
RepositorySystemSession s
 
         RequestTrace trace = RequestTrace.newChild(request.getTrace(), 
request);
 
-        List<? extends MetadataGenerator> generators = 
getMetadataGenerators(session, request);
+        final List<Artifact> artifacts = new 
ArrayList<>(request.getArtifacts());

Review Comment:
   Fixed



##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:
##########
@@ -151,7 +162,23 @@ private DeployResult deploy(SyncContext syncContext, 
RepositorySystemSession ses
             throw new DeploymentException("Failed to deploy 
artifacts/metadata: " + e.getMessage(), e);
         }
 
+        final List<Artifact> artifacts = new 
ArrayList<>(request.getArtifacts());

Review Comment:
   Fixed





> Artifact Generators
> -------------------
>
>                 Key: MRESOLVER-301
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-301
>             Project: Maven Resolver
>          Issue Type: New Feature
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0, 2.0.0-alpha-9
>
>
> Resolver should provide extension point for "generators". Typical use case 
> for these are for example "signing" of artifacts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to