[ 
https://issues.apache.org/jira/browse/MRESOLVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819764#comment-17819764
 ] 

ASF GitHub Bot commented on MRESOLVER-301:
------------------------------------------

cstamas commented on PR #432:
URL: https://github.com/apache/maven-resolver/pull/432#issuecomment-1960029880

   For other a general answer: I do agree with all your comments, but
   * Resolver whole codebase is done as this, and we may want to change all 
these, but for now there are a lot of package protected and final classes, I 
did not want to disturb this coherence. But I do agree about 
non-final/public/protected fields.
   * BUT, extending JSR330 annotated component is a no-no (hence final)
   * I like how these classes are being prevented to be tampered with. If 
someone needs this, can copy, but I don't want to be hindered a year after, as 
somecome tells me I broke "compatibility" with his app (where he uses or 
extends these classes).
   
   So, yes, I agree, but this is why not IMO.




> Artifact Generators
> -------------------
>
>                 Key: MRESOLVER-301
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-301
>             Project: Maven Resolver
>          Issue Type: New Feature
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0, 2.0.0-alpha-9
>
>
> Resolver should provide extension point for "generators". Typical use case 
> for these are for example "signing" of artifacts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to