[ 
https://issues.apache.org/jira/browse/ARCHETYPE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812012#comment-17812012
 ] 

ASF GitHub Bot commented on ARCHETYPE-654:
------------------------------------------

kwin commented on code in PR #185:
URL: https://github.com/apache/maven-archetype/pull/185#discussion_r1470033071


##########
maven-archetype-plugin/src/site/fml/faq.fml:
##########
@@ -35,11 +35,13 @@ under the License.
     </faq>
 
     <faq id="authentication">
-      <question>How to generate a project from an archetype in an 
authenticated repository?</question>
+      <question>How to generate a project from an archetype in a custom 
(potentially authenticated) repository?</question>
       <answer>
-        <p>The server id used to download the artifact is 
<code><i>[archetypeArtifactId]</i>-repo</code>: you have to

Review Comment:
   this repo id is format is still used in 
https://github.com/apache/maven-archetype/blob/3a2b725198c3823fd5d7e9f88b665b2e4515a202/archetype-common/src/main/java/org/apache/maven/archetype/generator/DefaultArchetypeGenerator.java#L70
 (i.e. for downloading the actual archetype (not the catalog)), not sure if it 
just acts as a fallback though.





> Clarify repository/server id used for custom repository catalog
> ---------------------------------------------------------------
>
>                 Key: ARCHETYPE-654
>                 URL: https://issues.apache.org/jira/browse/ARCHETYPE-654
>             Project: Maven Archetype
>          Issue Type: Improvement
>          Components: Generator
>    Affects Versions: 3.2.1
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> According to 
> https://maven.apache.org/archetype/maven-archetype-plugin/generate-mojo.html#archetypeArtifactId
>  a repository with id {{archetype}} can be used to resolve catalogs from a 
> remote repository. The same id is supposed to be used in case that repo uses 
> authentication. This contradicts the FAQ entry at 
> https://maven.apache.org/archetype/maven-archetype-plugin/faq.html#authentication
>  which states that the id is supposed to be {{<archetypeArtifactId>-repo}} 
> which would require one server section per archetype in a repo requiring 
> authentication.
> Also it is unclear which value {{archetypeArtifact}} should be set to to 
> consider the catalog from a specific remote repository as 
> bq. {{remote}} is the shortcut for Maven Central repository or its mirror. 
> But in case there is no mirror for Maven Central but rather a dedicated 
> catalog of custom archetypes maintained in a a custom repo the value is 
> unclear.
> Also adding a repository with id {{archetype}} to settings would not only 
> affect m-archetype-p but every resolution with Maven. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to