rmannibucau commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1460903860
########## api/maven-api-core/src/main/java/org/apache/maven/api/PathType.java: ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.api; + +import java.nio.file.Path; +import java.util.Objects; +import java.util.Optional; + +import org.apache.maven.api.annotations.Experimental; +import org.apache.maven.api.annotations.Nonnull; + +/** + * The option of a command-line tool where to place the paths to some dependencies. + * A {@code PathType} can identify the Java class-path, the Java module-path, + * or another kind of path for another programming language for example. + * This class is like an enumeration, except that it is extensible: + * plugins can define their own kinds of path. + * + * <p>Path types are often exclusive. For example, a dependency should not be both + * on the Java class-path and on the Java module-path.</p> + * + * @see DependencyProperties#PATH_TYPES + * @see org.apache.maven.api.services.DependencyResolverResult#getDispatchedPaths() + * + * @since 4.0.0 + */ +@Experimental +public abstract class PathType { Review Comment: > There is an official thing called Java® tools specification True but this is unrelated to this PR by the fact maven does not aim to target this scope but way more so question is do we put all we intend to support in core or not. For me answer can only be no otherwise core would quickly be bloated and we already saw it does not scale in time (in terms of maintenance). So overall you can reference any trademark but this stays out of topic for me, topic is what is the scope of core and it is the pipeline only for me and hopefully we'll be able to drop mvn 2 legacy remaining parts not respecting that historically. > This is not the case of WAR, EAR, OSGi, etc. Once again it is out of topic but there are a lot of shared parts there too so if you reasoning is right then we must embrace that too (it is default maven plugins too after all). > If you want Maven core to be language neutral and move all Java-specific stuff in a separated module shared by all Java plugins, I have no objection. Exactly. > But this is a separated debate (JavaPathType is not the only Java-specific thing currently in core). Not really, the point is that `JavaPathType` has not to exist in core but in `maven-java-tool-shared` module (whatever name it is). Core can stick to `String` since `option` doesnt always make sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
