desruisseaux commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1460857946
########## api/maven-api-core/src/main/java/org/apache/maven/api/PathType.java: ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.api; + +import java.nio.file.Path; +import java.util.Objects; +import java.util.Optional; + +import org.apache.maven.api.annotations.Experimental; +import org.apache.maven.api.annotations.Nonnull; + +/** + * The option of a command-line tool where to place the paths to some dependencies. + * A {@code PathType} can identify the Java class-path, the Java module-path, + * or another kind of path for another programming language for example. + * This class is like an enumeration, except that it is extensible: + * plugins can define their own kinds of path. + * + * <p>Path types are often exclusive. For example, a dependency should not be both + * on the Java class-path and on the Java module-path.</p> + * + * @see DependencyProperties#PATH_TYPES + * @see org.apache.maven.api.services.DependencyResolverResult#getDispatchedPaths() + * + * @since 4.0.0 + */ +@Experimental +public abstract class PathType { Review Comment: There is an official thing called _Java® tools specification_. Its content is the official standard according those who legally own the "Java" name for the programming language. Everything else is not Java. It may be called "OpenJDK", "Eclipse" or "Adoptium", but not Java. Whether the extra stuff is done by the same peoples or not is irrelevant to the _Java® tools specification_. The _Java® tools specification_ is only taken as a base. Any library or plugin can define its own `PathType`. The _Java® tools specification_ is considered a base worth to be in shared code because some of its concepts, such as class-path, are shared by almost all tools. This is not the case of WAR, EAR, OSGi, etc. We are not going to move plugins in core. We put there only the parts that are common to almost all Java tools, which is path management now, maybe `--add-exports` management later. Everything else stay in their plugins. If you want Maven core to be language neutral and move all Java-specific stuff in a separated module shared by all Java plugins, I have no objection. But this is a separated debate (`JavaPathType` is not the only Java-specific thing currently in core). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
