[ https://issues.apache.org/jira/browse/DOXIA-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808926#comment-17808926 ]
ASF GitHub Bot commented on DOXIA-723: -------------------------------------- michael-o commented on code in PR #194: URL: https://github.com/apache/maven-doxia/pull/194#discussion_r1460512526 ########## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractSink.java: ########## @@ -420,4 +424,17 @@ protected static String unifyEOLs(String text) { protected void init() { // nop } + + @Override + public void setDocumentLocator(Locator locator) { + this.locator = locator; + } + + @Override + public Locator getDocumentLocator() { Review Comment: I understand, I have no better idea to solve this... > Optionally expose document location in Sink > ------------------------------------------- > > Key: DOXIA-723 > URL: https://issues.apache.org/jira/browse/DOXIA-723 > Project: Maven Doxia > Issue Type: Improvement > Components: Sink API > Reporter: Konrad Windszus > Assignee: Konrad Windszus > Priority: Major > > Similar to http://www.saxproject.org/apidoc/org/xml/sax/Locator.html the Sink > API should provide means to figure out the document location. This should be > available whenever the Sink events are emitted from parsing a file. > The locator should expose file name, line number and column number. > This can be used enhance warning/errors as otherwise it is very hard to > figure out the root cause of messages like > https://github.com/apache/maven-doxia/blob/e01880801ca1283b86205e2f7064b9b4dbc84d54/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L930. -- This message was sent by Atlassian Jira (v8.20.10#820010)