[
https://issues.apache.org/jira/browse/DOXIA-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806022#comment-17806022
]
ASF GitHub Bot commented on DOXIA-723:
--------------------------------------
kwin commented on code in PR #194:
URL: https://github.com/apache/maven-doxia/pull/194#discussion_r1450314224
##########
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java:
##########
@@ -194,6 +215,7 @@ protected SinkEventAttributeSet
getAttributesFromParser(XmlPullParser parser) {
* @throws org.apache.maven.doxia.macro.MacroExecutionException if there's
a problem executing a macro
*/
private void parseXml(XmlPullParser parser, Sink sink) throws
XmlPullParserException, MacroExecutionException {
+ sink.setDocumentLocator(new XmlPullParserLocator(parser, null));
Review Comment:
@michael-o Is the 3rd argument of
https://maven.apache.org/doxia/doxia/doxia-core/apidocs/org/apache/maven/doxia/parser/Parser.html#parse-java.io.Reader-org.apache.maven.doxia.sink.Sink-java.lang.String-
supposed to contain the file path? The javadoc is a bit fuzzy here....
> Optionally expose document location in Sink
> -------------------------------------------
>
> Key: DOXIA-723
> URL: https://issues.apache.org/jira/browse/DOXIA-723
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Sink API
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Similar to http://www.saxproject.org/apidoc/org/xml/sax/Locator.html the Sink
> API should provide means to figure out the document location. This should be
> available whenever the Sink events are emitted from parsing a file.
> The locator should expose file name, line number and column number.
> This can be used enhance warning/errors as otherwise it is very hard to
> figure out the root cause of messages like
> https://github.com/apache/maven-doxia/blob/e01880801ca1283b86205e2f7064b9b4dbc84d54/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L930.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
