Re: [PR] [MSHADE-467] Fix concurrency problem with dependency-reduced POM [maven-shade-plugin]

[via GitHub]

kriegaex commented on code in PR #210:
URL: 
https://github.com/apache/maven-shade-plugin/pull/210#discussion_r1460317942


##########
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##########
@@ -1112,15 +1116,21 @@ private void 
rewriteDependencyReducedPomIfWeHaveReduction(
                     w.close();
                 }
 
-                ProjectBuildingRequest projectBuildingRequest =
-                        new 
DefaultProjectBuildingRequest(session.getProjectBuildingRequest());
-                
projectBuildingRequest.setLocalRepository(session.getLocalRepository());
-                
projectBuildingRequest.setRemoteRepositories(project.getRemoteArtifactRepositories());
+                // Lock critical section to fix MSHADE-467
+                try {

Review Comment:
   BTW, feel free to commit on top of the PR, we can always squash some commits 
later, as long as we keep the IT separate from the fix.
   
   
![image](https://github.com/apache/maven-shade-plugin/assets/1537384/140dd01b-d84d-4100-a42f-7085a7f05c00)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org