kriegaex commented on PR #210: URL: https://github.com/apache/maven-shade-plugin/pull/210#issuecomment-1901979558
OK, [this build](https://github.com/kriegaex/maven-shade-plugin/actions/runs/7593219673) has passed now. For Maven 3.9.6, synchronisation on a single session instance was enough, but for Maven 3.6.3 it was a bit too naive and optimistic. Complex objects like project, session etc. contain lots of nested stuff, and not everything can or even should be deep-cloned as was done in MSHADE-413 in another part of the mojo. That can work, but leads to potential brittle solutions, if the plugin needs to run on multiple Maven versions. So, protection of the critical section with a `ReentrantLock` it is, then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
