kwin commented on code in PR #188:
URL:
https://github.com/apache/maven-apache-parent/pull/188#discussion_r1452757436
##########
pom.xml:
##########
@@ -403,6 +403,26 @@ under the License.
</rules>
</configuration>
</execution>
+ <execution>
+ <id>enforce-maven.compiler.target-version</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <requireProperty>
+ <property>maven.compiler.target</property>
+ <regex>(?!1\.).*</regex>
+ <regexMessage>The value of property maven.compiler.target
must not start with "1.", use for example "8" instead of "1.8"!</regexMessage>
+ </requireProperty>
+ <requireProperty>
+ <property>maven.compiler.source</property>
+ <regex>(?!1\.).*</regex>
+ <regexMessage>The value of property maven.compiler.source
must not start with "1.", use for example "8" instead of "1.8"!</regexMessage>
+ </requireProperty>
+ </rules>
+ </configuration>
+ </execution>
Review Comment:
I removed the enforcement of the property in
https://github.com/apache/maven-apache-parent/pull/188/commits/8ab37cef72208e2b9667dbd298a446b16696ec66.
##########
pom.xml:
##########
@@ -525,6 +545,17 @@ under the License.
</build>
</profile>
<!-- END SNIPPET: release-profile -->
+ <profile>
+ <id>jdk9ornewer</id>
Review Comment:
Done in
https://github.com/apache/maven-apache-parent/pull/188/commits/8ab37cef72208e2b9667dbd298a446b16696ec66.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
