kwin commented on code in PR #188:
URL:
https://github.com/apache/maven-apache-parent/pull/188#discussion_r1452651203
##########
pom.xml:
##########
@@ -93,8 +93,9 @@ under the License.
<gpg.useagent>true</gpg.useagent>
<minimalMavenBuildVersion>3.6.3</minimalMavenBuildVersion>
<minimalJavaBuildVersion>1.8</minimalJavaBuildVersion>
+ <targetJavaVersion></targetJavaVersion>
<maven.compiler.source>${maven.compiler.target}</maven.compiler.source>
- <maven.compiler.target>1.7</maven.compiler.target>
+ <maven.compiler.target>7</maven.compiler.target><!-- use version numbers
without the "1." prefix (supported since javac 8) -->
Review Comment:
should we enforce with
https://maven.apache.org/enforcer/enforcer-rules/requireProperty.html that this
property value does no longer start with "1."?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]