kwin commented on code in PR #188:
URL:
https://github.com/apache/maven-apache-parent/pull/188#discussion_r1452660696
##########
pom.xml:
##########
@@ -93,8 +93,9 @@ under the License.
<gpg.useagent>true</gpg.useagent>
<minimalMavenBuildVersion>3.6.3</minimalMavenBuildVersion>
<minimalJavaBuildVersion>1.8</minimalJavaBuildVersion>
+ <targetJavaVersion></targetJavaVersion>
<maven.compiler.source>${maven.compiler.target}</maven.compiler.source>
- <maven.compiler.target>1.7</maven.compiler.target>
+ <maven.compiler.target>7</maven.compiler.target><!-- use version numbers
without the "1." prefix (supported since javac 8) -->
Review Comment:
yes it is: back to 5 if javac 8 is used,
https://docs.oracle.com/javase/8/docs/technotes/tools/windows/javac.html#BHCDIFEE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
