kwin commented on code in PR #194:
URL: https://github.com/apache/maven-doxia/pull/194#discussion_r1452150977


##########
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractSink.java:
##########
@@ -420,4 +424,17 @@ protected static String unifyEOLs(String text) {
     protected void init() {
         // nop
     }
+
+    @Override
+    public void setDocumentLocator(Locator locator) {
+        this.locator = locator;
+    }
+
+    @Override
+    public Locator getDocumentLocator() {

Review Comment:
   Any proposal on how to rename? Sinks are either used from a parser or 
manually. Obviously the locator primarily makes sense to the former. But the 
whole point of this PR and the related issue is that this should be available 
in sinks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to