michael-o commented on code in PR #194:
URL: https://github.com/apache/maven-doxia/pull/194#discussion_r1450351991
##########
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java:
##########
@@ -194,6 +215,7 @@ protected SinkEventAttributeSet
getAttributesFromParser(XmlPullParser parser) {
* @throws org.apache.maven.doxia.macro.MacroExecutionException if there's
a problem executing a macro
*/
private void parseXml(XmlPullParser parser, Sink sink) throws
XmlPullParserException, MacroExecutionException {
+ sink.setDocumentLocator(new XmlPullParserLocator(parser, null));
Review Comment:
See: https://issues.apache.org/jira/browse/DOXIA-224 and
https://github.com/apache/maven-doxia/commit/70642f0fd1dbc7d0fb7780d347b87e1fd9b2d1b0.
It seems to be a logical reference omitting the format. I think it is similar
to `generator` and `document`:
https://github.com/apache/maven-doxia-sitetools/blob/5fe4a4c5359e6a23b78f385e15f77767cadaee99/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DocumentRenderingContext.java#L66
See how I have been using it throughout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
