[
https://issues.apache.org/jira/browse/MPLUGIN-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806511#comment-17806511
]
ASF GitHub Bot commented on MPLUGIN-450:
----------------------------------------
rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891041901
> I also see some risk that different plugins now they are forced to, choose
some prefix that clashes in the name.
AFAIK it always had been the case, the heuristic always had been considered
bad but put there by compatibility when it got realized.
The fact plugin prefix is an identifier in a build - you can extend it to
globally on a pure theorical standpoint - had the issue you mention but only if
you call it from the CLI using the prefix - else it is ignored and not used -
and if we want to drop that constraint that it means we'll not enable to call
`prefix:goal` but will enforce `ga[v]:goal` which is a joke from a CLI
standpoint so guess we'll probably stay in the current status and maybe just
log the heuristic and show the plugin configuration to set to stay in the same
status, was not an issue before, it will not be tomorrow ;).
> Make goal prefix mandatory by default
> -------------------------------------
>
> Key: MPLUGIN-450
> URL: https://issues.apache.org/jira/browse/MPLUGIN-450
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
> Reporter: Tamas Cservenak
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 3.11.0
>
>
> The goal prefix currently is not mandatory, and plugin uses heuristic to
> figure it out, if possible (xxx-maven-plugin or maven-xxx-plugin, latter for
> org.apache.maven plugins ONLY).
> In general, goal prefix is optional, but "good to have", and usually is
> present.
> Cases when is not present, is when heuristics fails (so plugin module is not
> named as "xxx-maven-plugin" or "maven-xxx-plugin") and user did not provide
> one either. The cases when prefix is not present is mostly unintentional, but
> maven-plugin-plugin leaves this without any remark or warning.
> IMHO, the maven-plugin-plugin should either warn, or even fail the build in
> case when goal prefix is not present, but we may want to have some option to
> turn off this feature (for me unknown reasons, where it would be expected to
> NOT have goal prefix for a reason).
> TL;DR Am pretty much sure that in most of the cases when plugin developer
> ends up with plugin without prefix, that it was unintentional (and causes
> surprise later, not to mention refactoring the module name or POM change to
> configure it), while there MAY be cases where goal prefix is not desired for
> some reason (ie. plugin not mentioned for manual/CLI invocation). Simply put,
> the out of the box defaults should enforce presence of it, while advanced
> users still can produce prefix-less plugins with some extra configuration.
> This would make things more explicit as well: even if plugin is named as
> xxx-maven-plugin, configuration would be clear I do not want prefix for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
