[
https://issues.apache.org/jira/browse/MPLUGIN-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806507#comment-17806507
]
ASF GitHub Bot commented on MPLUGIN-450:
----------------------------------------
michael-o commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891039908
> @gnodet the JIRA mentions
>
> > but we may want to have some option to turn off this feature
>
> but it seems there is no such option as far as I can see?
>
> Can the "heuristics" maybe be enhanced to also accept `<prefix>-plugin`
and using then as a `prefix`? This seems to be the previous behavior here in
fact.
>
> e.g in Tycho there are several plugins named e.g.
`tycho-<somename>-plugin` and having them all renamed /relocated to
`tycho-<somename>-maven-plugin` seems not really usefull, also configuring a
prefix for each of them is possible we never needed any nor used any prefix as
the most natural choice would be `tycho` for all plugins but that seems not
possible....
>
> I also see some risk that different plugins now they are forced to, choose
some prefix that clashes in the name.
You should file a JIRA issue for any request which we can explore together...
> Make goal prefix mandatory by default
> -------------------------------------
>
> Key: MPLUGIN-450
> URL: https://issues.apache.org/jira/browse/MPLUGIN-450
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
> Reporter: Tamas Cservenak
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 3.11.0
>
>
> The goal prefix currently is not mandatory, and plugin uses heuristic to
> figure it out, if possible (xxx-maven-plugin or maven-xxx-plugin, latter for
> org.apache.maven plugins ONLY).
> In general, goal prefix is optional, but "good to have", and usually is
> present.
> Cases when is not present, is when heuristics fails (so plugin module is not
> named as "xxx-maven-plugin" or "maven-xxx-plugin") and user did not provide
> one either. The cases when prefix is not present is mostly unintentional, but
> maven-plugin-plugin leaves this without any remark or warning.
> IMHO, the maven-plugin-plugin should either warn, or even fail the build in
> case when goal prefix is not present, but we may want to have some option to
> turn off this feature (for me unknown reasons, where it would be expected to
> NOT have goal prefix for a reason).
> TL;DR Am pretty much sure that in most of the cases when plugin developer
> ends up with plugin without prefix, that it was unintentional (and causes
> surprise later, not to mention refactoring the module name or POM change to
> configure it), while there MAY be cases where goal prefix is not desired for
> some reason (ie. plugin not mentioned for manual/CLI invocation). Simply put,
> the out of the box defaults should enforce presence of it, while advanced
> users still can produce prefix-less plugins with some extra configuration.
> This would make things more explicit as well: even if plugin is named as
> xxx-maven-plugin, configuration would be clear I do not want prefix for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
