[
https://issues.apache.org/jira/browse/MPLUGIN-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806686#comment-17806686
]
ASF GitHub Bot commented on MPLUGIN-450:
----------------------------------------
rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891553087
> So for (1) it seems a lot of users where happy with that
I assume you mean for tycho case but it is really done under the carpet so
50-50 IMHO (implicit case is actually rare from what I saw so not sure it is
numerous enough to do stats :D).
> But why don't these user ever complained so the prefix was added before
this change?
You mix two things there: the producer and consumer sides. There is *no*
change for consumers (users), it only changes the way the producer sets the
prefix.
> why is apache-rat "wrong" and rat right
Don't think it is what you mean but didn't say `apache-rat` is wrong, what I
meant is that the concurrent prefix is an issue for users cause they don't know
which one to use. It is common to see an user using the wrong prefix on rat
failure and not getting the expected result.
> no one has complained
This is not true, not sure why you say that.
> Also the shorter the higher the risk of name-clashes can maven handle this
if two plugins use the same prefix or will it make these two plugins
incompatible to be used in the same build
Only if referenced from the prefix, not in all other cases.
> Make goal prefix mandatory by default
> -------------------------------------
>
> Key: MPLUGIN-450
> URL: https://issues.apache.org/jira/browse/MPLUGIN-450
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
> Reporter: Tamas Cservenak
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 3.11.0
>
>
> The goal prefix currently is not mandatory, and plugin uses heuristic to
> figure it out, if possible (xxx-maven-plugin or maven-xxx-plugin, latter for
> org.apache.maven plugins ONLY).
> In general, goal prefix is optional, but "good to have", and usually is
> present.
> Cases when is not present, is when heuristics fails (so plugin module is not
> named as "xxx-maven-plugin" or "maven-xxx-plugin") and user did not provide
> one either. The cases when prefix is not present is mostly unintentional, but
> maven-plugin-plugin leaves this without any remark or warning.
> IMHO, the maven-plugin-plugin should either warn, or even fail the build in
> case when goal prefix is not present, but we may want to have some option to
> turn off this feature (for me unknown reasons, where it would be expected to
> NOT have goal prefix for a reason).
> TL;DR Am pretty much sure that in most of the cases when plugin developer
> ends up with plugin without prefix, that it was unintentional (and causes
> surprise later, not to mention refactoring the module name or POM change to
> configure it), while there MAY be cases where goal prefix is not desired for
> some reason (ie. plugin not mentioned for manual/CLI invocation). Simply put,
> the out of the box defaults should enforce presence of it, while advanced
> users still can produce prefix-less plugins with some extra configuration.
> This would make things more explicit as well: even if plugin is named as
> xxx-maven-plugin, configuration would be clear I do not want prefix for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
