[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802243#comment-17802243 ]
ASF GitHub Bot commented on MNG-6776: ------------------------------------- michael-o commented on code in PR #1361: URL: https://github.com/apache/maven/pull/1361#discussion_r1440632936 ########## maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java: ########## @@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor<Mojo> implements Cloneab private String executeLifecycle; /** - * Description with reason of Mojo deprecation. Similar to Javadoc {@code @deprecated}. - * This will trigger a warning when a user tries to use a Mojo marked as deprecated. + * Specify the version when the Mojo was deprecated to the API. Similar to Javadoc deprecated. This will trigger a Review Comment: The only changes to this file on master I can find are 47e2d689d687358a85c2cdecc176cac36093817e and 5ce5591ae341188230d6ecca76c90bd0a786fcb2 I agree that they should be included as well. > Inconsistent list of parameters in MojoDescriptor > ------------------------------------------------- > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API > Affects Versions: 3.6.2 > Reporter: Sylwester Lachiewicz > Assignee: Tamas Cservenak > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)