lalmeras commented on PR #77: URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1832907067
Here is a branch with my proposal : https://github.com/lalmeras/maven-filtering/commits/MSHARED-1285 * first commit is a test refactor applied to existing master codebase * second commit applies @laeubi proposal. I restore original ignoreDelta when filters or output directory trigger *hasDelta=true*, as this is an expected behaviour from tests Both commits built with success with java 8 / java 17 / mvn 3.8. I finally understand why old tests work. It is because they relied only on Scanner behavior, and not isUptodate / hasDelta methods. So they accommodate nicely with the buggy TestIncrementalBuildContext. No work done on this issue's testcase. I can work on it if this first proposal seems OK. I do not open another PR; feel free to integrate my proposal in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
