lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1830852620
I dig into the test issue.
Test verifies the following behavior:
* two files with resource filtering are filtered; both files are copied to
target with `${time}` replaced by `time`
* one file is touched and an incremental build with time=notime is launched
* expected behavior is that only the touched file is updated; other file
keeps time value (instead of notime)
* after proposed fix, both files are processed
I think there is an issue with the test implementation.
`TestIncrementalBuildContext.isUptodate(File, File)` (that is called by custom
DirectoryScanner#isSelected, cf `buildContext.isUptodate(...)`) implementation
always return false, because `hasDelta(target)` always return true, because
hasDelta fails to resolve target path as a source path (cf getRelpath).
Not sure why, but the original code does not trigger
`TestIncrementalBuildContext.isUptodate()`. Other tests from project does not
call this method either.
So the issue for this test failure is in TestIncrementalBuildContext
(org.sonatype.plexus:plexus-build-api:tests). Not sure how to handle this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
