slawekjaranowski commented on code in PR #690:
URL: https://github.com/apache/maven-surefire/pull/690#discussion_r1404861469
##########
pom.xml:
##########
@@ -306,17 +308,13 @@
<classifier>runtime</classifier>
</dependency>
<dependency>
+ <!-- Do not upgrade, leads to test failures, needs analysis -->
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>5.9.3</version>
<type>pom</type>
<scope>import</scope>
</dependency>
- <dependency>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-xml</artifactId>
- <version>3.0.0</version>
- </dependency>
Review Comment:
I hope is is not used by any transitive dependencies 😄
##########
pom.xml:
##########
@@ -306,17 +308,13 @@
<classifier>runtime</classifier>
</dependency>
<dependency>
+ <!-- Do not upgrade, leads to test failures, needs analysis -->
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>5.9.3</version>
<type>pom</type>
<scope>import</scope>
</dependency>
- <dependency>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-xml</artifactId>
- <version>3.0.0</version>
- </dependency>
Review Comment:
I hope is is not used by any transitive dependencies 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
