[
https://issues.apache.org/jira/browse/MNG-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771090#comment-17771090
]
ASF GitHub Bot commented on MNG-7891:
-------------------------------------
laeubi commented on code in PR #1272:
URL: https://github.com/apache/maven/pull/1272#discussion_r1342685628
##########
maven-embedder/src/main/java/org/apache/maven/cli/ExtensionConfigurationModule.java:
##########
@@ -27,18 +27,18 @@
import org.apache.maven.internal.xml.XmlPlexusConfiguration;
import org.apache.maven.model.v4.MavenTransformer;
import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.codehaus.plexus.interpolation.AbstractValueSource;
import org.codehaus.plexus.interpolation.InterpolationException;
-import org.codehaus.plexus.interpolation.PropertiesBasedValueSource;
import org.codehaus.plexus.interpolation.StringSearchInterpolator;
class ExtensionConfigurationModule implements Module {
private final CoreExtensionEntry extension;
- private final CliRequest cliRequest;
+ private final AbstractValueSource valueSource;
- ExtensionConfigurationModule(CoreExtensionEntry extension, CliRequest
cliRequest) {
+ ExtensionConfigurationModule(CoreExtensionEntry extension,
AbstractValueSource valueSource) {
Review Comment:
```suggestion
ExtensionConfigurationModule(CoreExtensionEntry extension,
AbstractValueSource ... valueSources) {
```
> Support configuration in extensions.xml / <extension> elements
> --------------------------------------------------------------
>
> Key: MNG-7891
> URL: https://issues.apache.org/jira/browse/MNG-7891
> Project: Maven
> Issue Type: New Feature
> Reporter: Christoph Läubrich
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
> Currently one can not configure extensions as only mojos are configurable.
> It would be great to have a basic configuration support for both in
> extension.xml as well as in pom>extension elements.
> The Idea would be for extensions.xml to only have very limited support:
> # Only the extension itself can be configured, no inheritance or similar
> complex stuff
> # Only basic interpolation: e.g. user-properties and env-variable
> for pom>extension elements one might want to allow everything that is allowed
> for build>plugins
> To aquire such configuration I would like it to be injectable into a
> component like this:
> {code:java}
> @Inject
> @Named("extension:my.group.id:my.extension.id")
> private PlexusConfiguration config;
> {code}
> for the second case this should be call-sensitive in respect to the current
> active session project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
